feat: close all windows when parked and a door opens
Ports WinClose's SWI69 window control as an opt-in foreground service that is independent of ABRP: no token, no GPS, no upload cadence. The driver opening a door while the car is in P at a readable 0 km/h pulses UP at all four areas for five seconds, then STOP. Only the parts that serve that one behaviour are taken. WinClose's speed and time arming, configurable delay, warning beep, per-window modes and position reads are all absent — the target car is a Comfort trim whose motors carry no position sensor, so a close can be neither verified nor cancelled. The pulse, the door edge detector and the eligibility policy are pure classes with unit tests. STOP is attempted from a finally block on every exit, including an interrupted sleep, a refused write and a sender that throws, because a pulse that stops arriving leaves the motors wherever they were. Guards worth naming, several of them learned from reading WinClose rather than from the port itself: - A wake lock spans the pulse. This fires as the driver leaves, which is exactly when the head unit suspends; without it the glass can stop halfway with no STOP sent. - A fresh listener registration replays the door's current state. That replay seeds the edge detector instead of triggering it, or a binder reconnect while the door stands open would close the windows on someone halfway out. - WinClose's 60-second cooldown, so reaching back into the car does not run a second pulse. - The service stops itself on a non-SWI69 generation, and the switch is disabled unless the process holds system uid — only the unstable flavor declares android.uid.system, so a stable build could otherwise offer a toggle whose every command would fail. This is the project's first write to the vehicle. README, SECURITY, AGENTS, CONTRIBUTING and DISCLAIMER all claimed the app never writes; that claim is retracted and scoped rather than quietly left standing. Untested on a car. The feature is off by default. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
07d76700e0
commit
444732438d
+3
-2
@@ -4,8 +4,9 @@ This app runs on a car. That single fact drives everything below.
|
||||
|
||||
## Ground rules
|
||||
|
||||
1. **The app never writes to the vehicle.** It is read-only towards the car. A patch that
|
||||
introduces a write will be rejected regardless of how useful the feature is.
|
||||
1. **Telemetry never writes to the vehicle.** The opt-in SWI69 WinClose integration is
|
||||
the only write exception: four-window closing, gated on P and readable 0 km/h,
|
||||
with a bounded pulse and STOP on completion, interruption or failure.
|
||||
2. **A property that cannot be read is omitted, never defaulted.** Sending 0 for an
|
||||
unreadable battery level tells ABRP the car is empty and corrupts the user's route
|
||||
plan. Nullable in, absent from the payload.
|
||||
|
||||
Reference in New Issue
Block a user