feat: close all windows when parked and a door opens
Ports WinClose's SWI69 window control as an opt-in foreground service that is independent of ABRP: no token, no GPS, no upload cadence. The driver opening a door while the car is in P at a readable 0 km/h pulses UP at all four areas for five seconds, then STOP. Only the parts that serve that one behaviour are taken. WinClose's speed and time arming, configurable delay, warning beep, per-window modes and position reads are all absent — the target car is a Comfort trim whose motors carry no position sensor, so a close can be neither verified nor cancelled. The pulse, the door edge detector and the eligibility policy are pure classes with unit tests. STOP is attempted from a finally block on every exit, including an interrupted sleep, a refused write and a sender that throws, because a pulse that stops arriving leaves the motors wherever they were. Guards worth naming, several of them learned from reading WinClose rather than from the port itself: - A wake lock spans the pulse. This fires as the driver leaves, which is exactly when the head unit suspends; without it the glass can stop halfway with no STOP sent. - A fresh listener registration replays the door's current state. That replay seeds the edge detector instead of triggering it, or a binder reconnect while the door stands open would close the windows on someone halfway out. - WinClose's 60-second cooldown, so reaching back into the car does not run a second pulse. - The service stops itself on a non-SWI69 generation, and the switch is disabled unless the process holds system uid — only the unstable flavor declares android.uid.system, so a stable build could otherwise offer a toggle whose every command would fail. This is the project's first write to the vehicle. README, SECURITY, AGENTS, CONTRIBUTING and DISCLAIMER all claimed the app never writes; that claim is retracted and scoped rather than quietly left standing. Untested on a car. The feature is off by default. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5
parent
07d76700e0
commit
444732438d
@@ -78,8 +78,9 @@ same rule in time as well as in value: a GPS fix older than `max(5 min, 3 x your
|
||||
interval)` is dropped rather than resent, so a stale fix cannot report the car back at the
|
||||
place it set off from.
|
||||
|
||||
**The app never writes to the car.** It only reads. Any write path would be a bug; see
|
||||
[`SECURITY.md`](SECURITY.md).
|
||||
Telemetry only reads the car. An optional SWI69 WinClose integration can close the four
|
||||
windows while parked; this is the only vehicle-write feature. See configuration below
|
||||
and [`SECURITY.md`](SECURITY.md).
|
||||
|
||||
## Install
|
||||
The MG4 head unit hides Settings and APK install. The known route in:
|
||||
@@ -134,6 +135,39 @@ Typing a long API key and token on the car's on-screen keyboard is painful. Inst
|
||||
put them in a text file and tap **Import file** — see [Config file](#config-file) below.
|
||||
|
||||
## Configuration
|
||||
|
||||
On the **Upload Service** page, **Kapı açılınca camları kapat** enables the WinClose
|
||||
integration independently of ABRP. It is off by default and restarts with the head unit
|
||||
once enabled; no ABRP token, GPS permission, speed threshold or driving timer is needed.
|
||||
|
||||
The integration is adapted from the sibling WinClose `WindowHardware.kt`: SWI69
|
||||
`CarStateClient` door callback (transaction 6, value 0) triggers the VSM's
|
||||
`setVehicleWindowStatus` on all four areas. WinClose describes this as the driver-door
|
||||
signal; passenger-door coverage has not been established. No alternative door-property
|
||||
source is used. The car must be in P with readable speed exactly 0 km/h. Comfort windows
|
||||
receive UP (1) every 120 ms for five seconds, then STOP (0). P and speed are checked
|
||||
during the pulse too. Cancellation, a failed command, or leaving P/stationary state ends
|
||||
the pulse and attempts STOP on all windows. Duplicate door events and openings during
|
||||
an active pulse do not extend it, and WinClose's 60-second cooldown means reaching back
|
||||
into the car does not run a second pulse. A partial wake lock is held across the pulse,
|
||||
because the close fires exactly as the head unit is heading for suspend.
|
||||
|
||||
The feature is SWI69-only and needs the platform signature: the service stops itself on
|
||||
any other known generation, and the switch is disabled when the process does not hold
|
||||
system uid (only the unstable flavor declares `android.uid.system`).
|
||||
|
||||
**No cancellation is possible on a Comfort trim.** Its window motors carry no position
|
||||
sensor, so nothing can observe you working the switch, and there is no way to abort a
|
||||
pulse once it starts. Verify the motors' pinch behaviour on a parked car before relying
|
||||
on this — the windows travel while the driver's door is open.
|
||||
|
||||
No position sensor is assumed: a completed command is not confirmation that the windows
|
||||
closed. The existing WinClose pulse duration is the starting value, not a manufacturer
|
||||
guarantee. Vehicle testing of timing, permissions and motor behavior is still required.
|
||||
The APK keeps its existing application IDs and signing configuration (the unstable flavor
|
||||
already uses `android.uid.system`). WinClose's source license is unspecified; see its
|
||||
README before redistribution.
|
||||
|
||||
| Setting | Default | Notes |
|
||||
|---|---|---|
|
||||
| Upload frequency | 60 s | 15 / 30 / 60 / 120 / 300 s. Applies while driving |
|
||||
|
||||
Reference in New Issue
Block a user