feat: close all windows when parked and a door opens

Ports WinClose's SWI69 window control as an opt-in foreground service that is
independent of ABRP: no token, no GPS, no upload cadence. The driver opening a
door while the car is in P at a readable 0 km/h pulses UP at all four areas for
five seconds, then STOP.

Only the parts that serve that one behaviour are taken. WinClose's speed and
time arming, configurable delay, warning beep, per-window modes and position
reads are all absent — the target car is a Comfort trim whose motors carry no
position sensor, so a close can be neither verified nor cancelled.

The pulse, the door edge detector and the eligibility policy are pure classes
with unit tests. STOP is attempted from a finally block on every exit, including
an interrupted sleep, a refused write and a sender that throws, because a pulse
that stops arriving leaves the motors wherever they were.

Guards worth naming, several of them learned from reading WinClose rather than
from the port itself:

- A wake lock spans the pulse. This fires as the driver leaves, which is exactly
  when the head unit suspends; without it the glass can stop halfway with no
  STOP sent.
- A fresh listener registration replays the door's current state. That replay
  seeds the edge detector instead of triggering it, or a binder reconnect while
  the door stands open would close the windows on someone halfway out.
- WinClose's 60-second cooldown, so reaching back into the car does not run a
  second pulse.
- The service stops itself on a non-SWI69 generation, and the switch is disabled
  unless the process holds system uid — only the unstable flavor declares
  android.uid.system, so a stable build could otherwise offer a toggle whose
  every command would fail.

This is the project's first write to the vehicle. README, SECURITY, AGENTS,
CONTRIBUTING and DISCLAIMER all claimed the app never writes; that claim is
retracted and scoped rather than quietly left standing.

Untested on a car. The feature is off by default.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
TCFDONMEZ
2026-09-25 14:00:10 +03:00
co-authored by Claude Opus 5
parent 07d76700e0
commit 444732438d
18 changed files with 937 additions and 9 deletions
@@ -0,0 +1,52 @@
package com.evsuite.abrp;
import org.junit.Test;
import static org.junit.Assert.*;
public class WinCloseDoorSignalTest {
@Test public void firstOpenEventWorksWithoutDrivingOrArming() {
assertTrue(new WinCloseDoorSignal().opening(0));
}
@Test public void repeatedOpenIsIgnoredButAReopeningTriggers() {
WinCloseDoorSignal signal = new WinCloseDoorSignal();
assertFalse(signal.opening(2));
assertTrue(signal.opening(0));
assertFalse(signal.opening(0));
assertFalse(signal.opening(1));
assertFalse(signal.opening(2));
assertTrue(signal.opening(0));
}
@Test public void aSeededOpenDoorIsNotTreatedAsSomeoneOpeningIt() {
WinCloseDoorSignal signal = new WinCloseDoorSignal();
// What a fresh listener registration replays: the door is already open.
signal.seed(0);
assertFalse(signal.opening(0));
// Closing it and opening it again is a real edge.
assertFalse(signal.opening(2));
assertTrue(signal.opening(0));
}
@Test public void seedingAClosedDoorStillArmsTheNextOpening() {
WinCloseDoorSignal signal = new WinCloseDoorSignal();
signal.seed(2);
assertTrue(signal.opening(0));
}
@Test public void seedIgnoresAnInvalidReadingRatherThanRecordingIt() {
WinCloseDoorSignal signal = new WinCloseDoorSignal();
signal.seed(0);
signal.seed(-1);
assertFalse(signal.opening(0));
}
@Test public void invalidReadingDoesNotInventAnotherOpening() {
WinCloseDoorSignal signal = new WinCloseDoorSignal();
assertTrue(signal.opening(0));
assertFalse(signal.opening(-1));
assertFalse(signal.opening(0));
signal.reset();
assertTrue(signal.opening(0));
}
}
@@ -0,0 +1,53 @@
package com.evsuite.abrp;
import org.junit.Test;
import static org.junit.Assert.*;
public class WindowClosePolicyTest {
@Test public void onlyKnownParkAndStandstillCanStart() {
WindowClosePolicy policy = new WindowClosePolicy();
assertFalse(policy.begin(null, 0f));
assertFalse(policy.begin(false, 0f));
assertFalse(policy.begin(true, null));
assertFalse(policy.begin(true, 0.1f));
assertFalse(policy.begin(true, -1f));
assertFalse(policy.begin(true, Float.NaN));
assertFalse(policy.begin(true, Float.POSITIVE_INFINITY));
assertTrue(policy.begin(true, 0f));
}
@Test public void openingsDuringACloseCannotExtendOrQueueIt() {
long[] now = {0L};
WindowClosePolicy policy = new WindowClosePolicy(() -> now[0]);
assertTrue(policy.begin(true, 0f));
assertFalse(policy.begin(true, 0f));
assertFalse(policy.begin(true, 0f));
policy.finish();
// A later, distinct opening needs no previous drive or arming timer.
now[0] += WindowClosePolicy.COOLDOWN_MS;
assertTrue(policy.begin(true, 0f));
}
@Test public void reopeningTheDoorWithinTheCooldownDoesNotCloseAgain() {
long[] now = {0L};
WindowClosePolicy policy = new WindowClosePolicy(() -> now[0]);
assertTrue(policy.begin(true, 0f));
now[0] += 5_000L;
policy.finish();
// Reaching back into the car reopens the door; the glass must not run a second pulse.
now[0] += WindowClosePolicy.COOLDOWN_MS - 1;
assertFalse(policy.begin(true, 0f));
now[0] += 1;
assertTrue(policy.begin(true, 0f));
}
@Test public void theCooldownIsMeasuredFromTheEndOfTheCloseNotItsStart() {
long[] now = {0L};
WindowClosePolicy policy = new WindowClosePolicy(() -> now[0]);
assertTrue(policy.begin(true, 0f));
now[0] += WindowClosePulse.DURATION_MS;
policy.finish();
now[0] += WindowClosePolicy.COOLDOWN_MS - WindowClosePulse.DURATION_MS;
assertFalse(policy.begin(true, 0f));
}
}
@@ -0,0 +1,84 @@
package com.evsuite.abrp;
import org.junit.Test;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import static org.junit.Assert.*;
public class WindowClosePulseTest {
private final List<String> writes = new ArrayList<>();
private long now;
private boolean send(int area, int command) {
writes.add(area + ":" + command);
return true;
}
private void assertStoppedAll() {
assertEquals(Arrays.asList("0:0", "1:0", "2:0", "3:0"),
writes.subList(writes.size() - 4, writes.size()));
}
@Test public void comfortPulseTargetsAllFourAndEndsAtFiveSeconds() {
assertTrue(WindowClosePulse.run(() -> true, this::send, () -> now, ms -> now += ms));
assertEquals(5_000L, now);
assertEquals(Arrays.asList("0:1", "1:1", "2:1", "3:1"), writes.subList(0, 4));
// Forty-two UP batches at 120 ms intervals, followed by a single STOP batch.
assertEquals(42 * 4 + 4, writes.size());
assertStoppedAll();
}
@Test public void refusedStartWritesNothing() {
assertFalse(WindowClosePulse.run(() -> false, this::send, () -> now, ms -> now += ms));
assertTrue(writes.isEmpty());
}
@Test public void leavingParkMovingOrDisablingStopsAtNextPulse() {
assertFalse(WindowClosePulse.run(() -> now < 120L, this::send, () -> now, ms -> now += ms));
assertEquals(8, writes.size());
assertStoppedAll();
}
@Test public void interruptionReleasesEveryWindowAndPreservesInterrupt() {
try {
assertFalse(WindowClosePulse.run(() -> true, this::send, () -> now,
ms -> { throw new InterruptedException(); }));
assertTrue(Thread.currentThread().isInterrupted());
assertStoppedAll();
} finally {
Thread.interrupted();
}
}
@Test public void oneFailedCommandEndsPulseAndReleasesEveryWindow() {
assertFalse(WindowClosePulse.run(() -> true, (area, command) -> {
send(area, command);
return area != 2 || command == 0;
}, () -> now, ms -> now += ms));
assertEquals(0L, now);
assertStoppedAll();
}
@Test public void unexpectedFailureStillReleasesEveryWindow() {
try {
WindowClosePulse.run(() -> true, (area, command) -> {
send(area, command);
if (area == 1 && command == 1) throw new IllegalStateException();
return true;
}, () -> now, ms -> now += ms);
fail("Expected sender failure");
} catch (IllegalStateException expected) {
assertStoppedAll();
}
}
@Test public void aFailedStopDoesNotPreventOtherStops() {
assertFalse(WindowClosePulse.run(() -> true, (area, command) -> {
send(area, command);
if (area == 0 && command == 0) throw new IllegalStateException();
return true;
}, () -> now, ms -> now += ms));
assertStoppedAll();
}
}