Correct SWI69 distance scale
This commit is contained in:
@@ -28,7 +28,7 @@ object VehicleSpeedScale {
|
||||
* route of known length, both over by the same 3.5x, with the adapter odometer as the
|
||||
* independent reference. Add a generation here only with the same kind of evidence.
|
||||
*/
|
||||
private val REPORTS_KMH = setOf(FirmwareInfo.Gen.SWI68)
|
||||
private val REPORTS_KMH = setOf(FirmwareInfo.Gen.SWI68, FirmwareInfo.Gen.SWI69)
|
||||
|
||||
/** True when this generation needs no conversion at all. */
|
||||
fun reportsKmh(generation: FirmwareInfo.Gen): Boolean = generation in REPORTS_KMH
|
||||
|
||||
@@ -7,14 +7,16 @@ import org.junit.Test
|
||||
|
||||
class VehicleSpeedScaleTest {
|
||||
|
||||
@Test fun `SWI68 reports km per hour and is not converted again`() {
|
||||
@Test fun `SWI68 and SWI69 report km per hour and are not converted again`() {
|
||||
assertTrue(VehicleSpeedScale.reportsKmh(FirmwareInfo.Gen.SWI68))
|
||||
assertTrue(VehicleSpeedScale.reportsKmh(FirmwareInfo.Gen.SWI69))
|
||||
assertEquals(34.4f, VehicleSpeedScale.toKmh(34.4f, FirmwareInfo.Gen.SWI68), 0.001f)
|
||||
assertEquals(34.4f, VehicleSpeedScale.toKmh(34.4f, FirmwareInfo.Gen.SWI69), 0.001f)
|
||||
}
|
||||
|
||||
@Test fun `an unproven generation keeps the specified conversion`() {
|
||||
FirmwareInfo.Gen.entries
|
||||
.filterNot { it == FirmwareInfo.Gen.SWI68 }
|
||||
.filterNot { it == FirmwareInfo.Gen.SWI68 || it == FirmwareInfo.Gen.SWI69 }
|
||||
.forEach { generation ->
|
||||
assertFalse("$generation is not proven", VehicleSpeedScale.reportsKmh(generation))
|
||||
assertEquals(
|
||||
@@ -28,7 +30,7 @@ class VehicleSpeedScaleTest {
|
||||
|
||||
@Test fun `reverse is a speed, not a negative one`() {
|
||||
assertEquals(12.0f, VehicleSpeedScale.toKmh(-12.0f, FirmwareInfo.Gen.SWI68), 0.001f)
|
||||
assertEquals(36.0f, VehicleSpeedScale.toKmh(-10.0f, FirmwareInfo.Gen.SWI69), 0.001f)
|
||||
assertEquals(10.0f, VehicleSpeedScale.toKmh(-10.0f, FirmwareInfo.Gen.SWI69), 0.001f)
|
||||
}
|
||||
|
||||
@Test fun `the drive that proved it now integrates to the route it followed`() {
|
||||
|
||||
Reference in New Issue
Block a user