TCFDONMEZandClaude Opus 5
444732438d
Ports WinClose's SWI69 window control as an opt-in foreground service that is independent of ABRP: no token, no GPS, no upload cadence. The driver opening a door while the car is in P at a readable 0 km/h pulses UP at all four areas for five seconds, then STOP. Only the parts that serve that one behaviour are taken. WinClose's speed and time arming, configurable delay, warning beep, per-window modes and position reads are all absent — the target car is a Comfort trim whose motors carry no position sensor, so a close can be neither verified nor cancelled. The pulse, the door edge detector and the eligibility policy are pure classes with unit tests. STOP is attempted from a finally block on every exit, including an interrupted sleep, a refused write and a sender that throws, because a pulse that stops arriving leaves the motors wherever they were. Guards worth naming, several of them learned from reading WinClose rather than from the port itself: - A wake lock spans the pulse. This fires as the driver leaves, which is exactly when the head unit suspends; without it the glass can stop halfway with no STOP sent. - A fresh listener registration replays the door's current state. That replay seeds the edge detector instead of triggering it, or a binder reconnect while the door stands open would close the windows on someone halfway out. - WinClose's 60-second cooldown, so reaching back into the car does not run a second pulse. - The service stops itself on a non-SWI69 generation, and the switch is disabled unless the process holds system uid — only the unstable flavor declares android.uid.system, so a stable build could otherwise offer a toggle whose every command would fail. This is the project's first write to the vehicle. README, SECURITY, AGENTS, CONTRIBUTING and DISCLAIMER all claimed the app never writes; that claim is retracted and scoped rather than quietly left standing. Untested on a car. The feature is off by default. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
54 lines
2.1 KiB
Java
54 lines
2.1 KiB
Java
package com.evsuite.abrp;
|
|
|
|
import org.junit.Test;
|
|
import static org.junit.Assert.*;
|
|
|
|
public class WindowClosePolicyTest {
|
|
@Test public void onlyKnownParkAndStandstillCanStart() {
|
|
WindowClosePolicy policy = new WindowClosePolicy();
|
|
assertFalse(policy.begin(null, 0f));
|
|
assertFalse(policy.begin(false, 0f));
|
|
assertFalse(policy.begin(true, null));
|
|
assertFalse(policy.begin(true, 0.1f));
|
|
assertFalse(policy.begin(true, -1f));
|
|
assertFalse(policy.begin(true, Float.NaN));
|
|
assertFalse(policy.begin(true, Float.POSITIVE_INFINITY));
|
|
assertTrue(policy.begin(true, 0f));
|
|
}
|
|
|
|
@Test public void openingsDuringACloseCannotExtendOrQueueIt() {
|
|
long[] now = {0L};
|
|
WindowClosePolicy policy = new WindowClosePolicy(() -> now[0]);
|
|
assertTrue(policy.begin(true, 0f));
|
|
assertFalse(policy.begin(true, 0f));
|
|
assertFalse(policy.begin(true, 0f));
|
|
policy.finish();
|
|
// A later, distinct opening needs no previous drive or arming timer.
|
|
now[0] += WindowClosePolicy.COOLDOWN_MS;
|
|
assertTrue(policy.begin(true, 0f));
|
|
}
|
|
|
|
@Test public void reopeningTheDoorWithinTheCooldownDoesNotCloseAgain() {
|
|
long[] now = {0L};
|
|
WindowClosePolicy policy = new WindowClosePolicy(() -> now[0]);
|
|
assertTrue(policy.begin(true, 0f));
|
|
now[0] += 5_000L;
|
|
policy.finish();
|
|
// Reaching back into the car reopens the door; the glass must not run a second pulse.
|
|
now[0] += WindowClosePolicy.COOLDOWN_MS - 1;
|
|
assertFalse(policy.begin(true, 0f));
|
|
now[0] += 1;
|
|
assertTrue(policy.begin(true, 0f));
|
|
}
|
|
|
|
@Test public void theCooldownIsMeasuredFromTheEndOfTheCloseNotItsStart() {
|
|
long[] now = {0L};
|
|
WindowClosePolicy policy = new WindowClosePolicy(() -> now[0]);
|
|
assertTrue(policy.begin(true, 0f));
|
|
now[0] += WindowClosePulse.DURATION_MS;
|
|
policy.finish();
|
|
now[0] += WindowClosePolicy.COOLDOWN_MS - WindowClosePulse.DURATION_MS;
|
|
assertFalse(policy.begin(true, 0f));
|
|
}
|
|
}
|