Posters: re-place after a resize, measure cell size without padding, log failed posters

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

SPECS.md

@@ -64,9 +64,9 @@ Notes:
   - Global speed / pause state in the status bar. Pause/resume and delete a SABnzbd job.
 - **Status bar / help:** the bottom bar lists the keys that work in the current view or panel; the top right shows the connection state of each service; `F9` opens the full key reference.
 - **Posters:** the detail panes show the poster at the top right; the head (title, facts, path) and the plot are one text that flows along the poster's left side and continues at full width below it (text is wrapped by arr-tui itself, with a narrower width for the first lines); on panes too small for the poster, the text simply uses the full width. Two ways to draw the poster, chosen by `ui.cover_style`:
-  - **Real images** (`kitty`, and `auto` in kitty/Ghostty): the Kitty graphics protocol with Unicode placeholders. The poster (kept up to 640 px tall) is uploaded once as PNG (`a=t,f=100,q=2`, 4096-byte base64 chunks), placed virtually with the cell footprint (`a=p,U=1,c=,r=`; a new size deletes and recreates the placement), and shown by writing U+10EEEE placeholder characters whose combining marks give row and column (the 297-entry table from the protocol) and whose foreground color is the image id. Since it is ordinary text, popups, dialogs and view changes cover it correctly and tcell's diffing keeps it in place. The footprint uses the real cell size in pixels (from the terminal's window size) and a box whose shape is within 3% of the poster's; the remaining sliver is cropped from the poster's edges before upload (one upload per size, the previous one is deleted), because the terminal letterboxes an image that does not fit its box exactly. As a second safeguard the placeholder cells use the panes' background color, so anything the picture does not cover blends in (without it the terminal's own, slightly different, default background showed as grey bars beside the poster). Writes to the terminal go through the screen's tty on the UI goroutine, so they cannot interleave with drawing. Requires 24-bit color; otherwise, and inside tmux/screen, the block fallback is used. Terminals are recognised from `TERM`/`TERM_PROGRAM`/`KITTY_WINDOW_ID`/`GHOSTTY_RESOURCES_DIR`. The go-termimg library was looked at and not used: its placeholder support is marked experimental, its diacritic table does not match the protocol's, and it writes images straight to the terminal instead of through the screen.
+  - **Real images** (`kitty`, and `auto` in kitty/Ghostty): the Kitty graphics protocol with Unicode placeholders. The poster (kept up to 640 px tall) is uploaded once as PNG (`a=t,f=100,q=2`, 4096-byte base64 chunks), placed virtually with the cell footprint (`a=p,U=1,c=,r=`; a new size deletes and recreates the placement), and shown by writing U+10EEEE placeholder characters whose combining marks give row and column (the 297-entry table from the protocol) and whose foreground color is the image id. Since it is ordinary text, popups, dialogs and view changes cover it correctly and tcell's diffing keeps it in place. The footprint uses the real cell size in pixels (the window's pixel size divided by its cell count, rounded down to whole pixels so padding around the grid does not skew it; the placements are made again whenever the window or cell size changes) and a box whose shape is within 3% of the poster's; the remaining sliver is cropped from the poster's edges before upload (one upload per size, the previous one is deleted), because the terminal letterboxes an image that does not fit its box exactly. As a second safeguard the placeholder cells use the panes' background color, so anything the picture does not cover blends in (without it the terminal's own, slightly different, default background showed as grey bars beside the poster). Writes to the terminal go through the screen's tty on the UI goroutine, so they cannot interleave with drawing. Requires 24-bit color; otherwise, and inside tmux/screen, the block fallback is used. Terminals are recognised from `TERM`/`TERM_PROGRAM`/`KITTY_WINDOW_ID`/`GHOSTTY_RESOURCES_DIR`. The go-termimg library was looked at and not used: its placeholder support is marked experimental, its diacritic table does not match the protocol's, and it writes images straight to the terminal instead of through the screen.
   - **Block characters** (`quadrant`, `sextant`, and the fallback): every cell shows several pixels in the best two-color split (`quadrant`: 2×2 pixels, glyphs from the Block Elements range every font has; `sextant`: 2×3 pixels, sharper, glyphs from Symbols for Legacy Computing). `auto` picks sextants on kitty, WezTerm, foot and Ghostty, and on other terminals when fontconfig lists a font with the sextant characters (`fc-list :charset=1fb00`, about 20 ms at startup; terminals draw glyphs their font lacks from fallback fonts; skipped over SSH because the installed fonts are the remote machine's), and quadrants otherwise.
-  Posters are JPEG/PNG, decoded and downscaled in the process. Library items fetch `/MediaCover/<id>/poster-250.jpg` from their Radarr/Sonarr instance with the API key; search results fall back to the provider's `remoteUrl` (fetched without credentials). Posters are cached in memory (the terminal's copies are deleted when the cache is dropped and on exit), failed downloads are not retried for two minutes, and the poster shrinks or disappears when the pane is too short. `ui.covers: false` disables it.
+  Posters are JPEG/PNG, decoded and downscaled in the process. Library items fetch `/MediaCover/<id>/poster-250.jpg` from their Radarr/Sonarr instance with the API key; search results fall back to the provider's `remoteUrl` (fetched without credentials). Posters are cached in memory (the terminal's copies are deleted when the cache is dropped and on exit), failed downloads are not retried for two minutes and are written to the Log (F7) with the reason, and the poster shrinks or disappears when the pane is too short. `ui.covers: false` disables it.
 - **Calendar view (F5):** a two-week window (starting today, moved a week at a time with `[`/`]`, `t` returns to today) with the library's movie releases and airing episodes, grouped by day. Radarr `GET /calendar` supplies the cinema, digital and physical release dates (taken as written: midnight UTC means that calendar day) and Sonarr `GET /calendar?includeSeries=true` the episodes with their air time (shown in local time). Unmonitored items are included with `u`. A movie appears once per release date in the window. Each entry shows type, title, episode or release kind and status (downloaded / missing / upcoming); the detail pane shows poster and plot; `Enter`/`i` starts the release search and `s` an automatic search.
 - **Download notifications:** a background poller (independent of the visible view) reads SABnzbd's history every 15 s and announces downloads that reach `Completed` or `Failed` as a popup and log entry; the first poll only records the current state. `ui.notify_downloads` (default true) and `ui.bell` (default false, rings the terminal bell) control it. Connection errors are not reported here, the indicators and the log already do that.
 - **Config view (F6):** one list with a field for every setting of the config file, one below the other under the headings Radarr, Sonarr, SABnzbd and Interface (a single scrolling form; ↑↓ passes over the headings and ↓ after the last field reaches the Save / Revert buttons, so no Tab is needed; Tab jumps between the fields and the buttons). The `Test` button is part of the list, right below the SABnzbd settings; `Save` and `Revert` are centered in a bar below the list. The fields start from the settings in use; API keys are masked (a checkbox shows them). `Test` builds temporary clients from the typed values and reports each service. `Save` validates like startup does (URLs, non-empty keys, refresh 1–3600 s), then writes the file from the file's own contents plus the edits (`config.LoadFile`), so values that only come from `ARR_TUI_*` environment variables are left as the file has them and are shown greyed out; the write is atomic (temp file + rename) and keeps the file's permissions (`0600` when new); defaults such as `covers: true` stay out of the file unless it already named them. Everything then applies without a restart: the Radarr/Sonarr/SABnzbd clients are re-pointed (`Reconfigure`, guarded by a mutex), the connection indicators, add-form defaults and options are refreshed, the library and calendar reload, the Downloads interval, notifications, bell and poster style are switched live. `q` is typed text in this view (`F9` opens the help).

internal/ui/app.go

@@ -66,6 +66,7 @@ type App struct {
 	covers     bool // poster thumbnails enabled
 	coverStyle coverStyle
 	gfx        *kittyGraphics // real-image posters, nil when not used
+	lastWindow [3]int         // columns, rows and cell shape at the last draw
 	cellAspect float64        // height of a terminal cell divided by its width
 	coverCache *coverCache
 }
@@ -181,6 +182,7 @@ func New(cfg *config.Config) *App {
 		s.HideCursor()
 		a.screen = s
 		a.cellAspect = cellAspectOf(s)
+		a.noteWindow(s)
 		return false
 	})
 	a.app.SetRoot(&toastRoot{Flex: layout, app: a}, true).EnableMouse(false)
@@ -190,6 +192,22 @@ func New(cfg *config.Config) *App {
 	return a
 }
 
+// noteWindow notices when the terminal's size or cell size changed. The
+// placements of real-image posters are then made again: the picture would
+// otherwise rely on the terminal rescaling an existing placement correctly.
+func (a *App) noteWindow(s tcell.Screen) {
+	w, h := s.Size()
+	win := [3]int{w, h, int(a.cellAspect * 1000)}
+	if win == a.lastWindow {
+		return
+	}
+	first := a.lastWindow == [3]int{}
+	a.lastWindow = win
+	if !first && a.gfx != nil {
+		a.gfx.invalidate()
+	}
+}
+
 // writeTerminal sends raw bytes (graphics commands) to the terminal through the
 // screen's own connection. UI goroutine only, so it stays in step with drawing.
 func (a *App) writeTerminal(b []byte) error {
@@ -208,13 +226,29 @@ func (a *App) writeTerminal(b []byte) error {
 // pixels; 2 when the terminal does not report pixel sizes.
 func cellAspectOf(s tcell.Screen) float64 {
 	if tty, ok := s.Tty(); ok {
-		if ws, err := tty.WindowSize(); err == nil && ws.Width > 0 && ws.Height > 0 && ws.PixelWidth > 0 && ws.PixelHeight > 0 {
-			return (float64(ws.PixelHeight) / float64(ws.Height)) / (float64(ws.PixelWidth) / float64(ws.Width))
+		if ws, err := tty.WindowSize(); err == nil {
+			return cellAspectFromWindow(ws.Width, ws.Height, ws.PixelWidth, ws.PixelHeight)
 		}
 	}
 	return 2
 }
 
+// cellAspectFromWindow derives the cell shape from the window size in cells
+// and pixels. The pixel size usually includes some padding around the cell
+// grid, which would skew a plain division (more with a small grid, and it
+// changes while the window is resized); cell sizes are whole pixels, so the
+// division is rounded down, which drops that padding.
+func cellAspectFromWindow(cols, rows, pixelW, pixelH int) float64 {
+	if cols <= 0 || rows <= 0 || pixelW <= 0 || pixelH <= 0 {
+		return 2
+	}
+	cw, ch := pixelW/cols, pixelH/rows
+	if cw <= 0 || ch <= 0 {
+		return 2
+	}
+	return float64(ch) / float64(cw)
+}
+
 // coverMaxHeight is how tall the stored poster copies are: real images keep
 // more detail than block characters need.
 func (a *App) coverMaxHeight() int {

internal/ui/cover.go

@@ -8,6 +8,7 @@ import (
 	"image/color"
 	_ "image/jpeg" // poster formats
 	_ "image/png"
+	"net/url"
 	"os/exec"
 	"strings"
 	"time"
@@ -503,6 +504,8 @@ func (a *App) loadCover(ref coverRef, done func(*image.RGBA, error)) {
 			delete(c.waiting, ref.key)
 			if err != nil {
 				c.failed[ref.key] = time.Now()
+				// Say why in the log: a poster that silently never shows up is hard to diagnose.
+				a.logs.add(levelWarn, "Poster not loaded ("+posterSource(ref.key)+"): "+err.Error())
 			} else {
 				if len(c.imgs) >= maxCoverCache {
 					c.imgs = map[string]*image.RGBA{} // simple bound; posters are cheap to fetch again
@@ -518,3 +521,16 @@ func (a *App) loadCover(ref coverRef, done func(*image.RGBA, error)) {
 		})
 	}()
 }
+
+// posterSource describes where a poster key points, for the log: the host and
+// file name of a remote image, or the path on the Radarr/Sonarr instance.
+func posterSource(key string) string {
+	if _, local, ok := strings.Cut(key, "|"); ok {
+		key = local
+	}
+	if u, err := url.Parse(key); err == nil && u.Host != "" {
+		return u.Host + u.Path
+	}
+	path, _, _ := strings.Cut(key, "?")
+	return path
+}

internal/ui/kitty.go

@@ -124,6 +124,15 @@ func (k *kittyGraphics) place(id uint32, cols, rows int) error {
 	return nil
 }
 
+// invalidate drops every placement (the uploaded pictures stay) so the next
+// draw places them again, e.g. after the terminal was resized.
+func (k *kittyGraphics) invalidate() {
+	for id := range k.placed {
+		_ = k.write(kittyAPC(fmt.Sprintf("a=d,d=i,i=%d,q=2", id), nil))
+	}
+	k.placed = map[uint32][2]int{}
+}
+
 // deleteAll removes every image uploaded so far from the terminal.
 func (k *kittyGraphics) deleteAll() {
 	for _, id := range k.ids {

internal/ui/kitty_test.go

@@ -279,3 +279,51 @@ func TestCropToBox(t *testing.T) {
 		t.Errorf("offset image: %v", got)
 	}
 }
+
+func TestInvalidateReplacesPlacements(t *testing.T) {
+	rec := &recorder{}
+	k := newKittyGraphics(rec.write)
+	k.place(3, 17, 13)
+	k.place(4, 10, 8)
+	rec.cmds = nil
+	k.invalidate()
+	if len(rec.cmds) != 2 || !strings.Contains(strings.Join(rec.cmds, ""), "a=d,d=i,i=3") || !strings.Contains(strings.Join(rec.cmds, ""), "a=d,d=i,i=4") {
+		t.Fatalf("invalidate sent %q", rec.cmds)
+	}
+	// The same size is placed again afterwards, since the placement is gone.
+	rec.cmds = nil
+	k.place(3, 17, 13)
+	if len(rec.cmds) != 1 || !strings.Contains(rec.cmds[0], "a=p,U=1,i=3,c=17,r=13") {
+		t.Errorf("after invalidate: %q", rec.cmds)
+	}
+}
+
+func TestCellAspectFromWindow(t *testing.T) {
+	// 140×50 cells of 9×20 px plus 4 and 11 px of padding: plain division
+	// would say 1264/140=9.03 and 1011/50=20.22 (aspect 2.24), the real shape is 20/9.
+	if got := cellAspectFromWindow(140, 50, 140*9+4, 50*20+11); math.Abs(got-20.0/9) > 1e-9 {
+		t.Errorf("aspect = %v, want %v", got, 20.0/9)
+	}
+	// Padding that grows with the window does not move it.
+	for _, pad := range []int{0, 3, 8} {
+		if got := cellAspectFromWindow(100, 30, 100*10+pad, 30*21+pad); math.Abs(got-2.1) > 1e-9 {
+			t.Errorf("padding %d: aspect = %v", pad, got)
+		}
+	}
+	for _, bad := range [][4]int{{0, 10, 100, 100}, {10, 0, 100, 100}, {10, 10, 0, 100}, {10, 10, 100, 0}, {100, 100, 50, 50}} {
+		if got := cellAspectFromWindow(bad[0], bad[1], bad[2], bad[3]); got != 2 {
+			t.Errorf("%v: aspect = %v, want the default 2", bad, got)
+		}
+	}
+}
+
+func TestPosterSource(t *testing.T) {
+	for in, want := range map[string]string{
+		"https://artworks.thetvdb.com/banners/posters/1-1.jpg":    "artworks.thetvdb.com/banners/posters/1-1.jpg",
+		"http://radarr:7878|/MediaCover/1/poster.jpg?lastWrite=5": "/MediaCover/1/poster.jpg",
+	} {
+		if got := posterSource(in); got != want {
+			t.Errorf("posterSource(%q) = %q, want %q", in, got, want)
+		}
+	}
+}